Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Bike Battery #47

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added Bike Battery #47

wants to merge 7 commits into from

Conversation

Bamuel
Copy link
Contributor

@Bamuel Bamuel commented Aug 1, 2024 •
edited
Loading

Issue: #38

Just a basic bike percentage.
image

Added a rule if battery = 0
then it wont show, this happens on first load, but is now hidden with an if statement

  • Gets the value and updates the State, (no need to save in db / write to bike).
  • Other Changes, such as Debug mode generates a random macaddress
  • Added Git Attributes, to cleanup/resolve the CR/ CRLF changes (mac/linux vs windows new line)

@blopker
Copy link
Owner

blopker commented Aug 2, 2024

Hm. Is there a better way to display this data? To me it looks like connection strength, not battery level.

@Bamuel
Copy link
Contributor Author

Bamuel commented Aug 2, 2024

Hm. Is there a better way to display this data? To me it looks like connection strength, not battery level.

Okay will try another way on Monday

@Bamuel
Copy link
Contributor Author

Bamuel commented Aug 5, 2024 •
edited
Loading

image

I like the 2 small bubbles.
but I don't like the range showing?

@blopker any other ideas of what to show instead of range?

@Bamuel
Copy link
Contributor Author

Bamuel commented Aug 6, 2024

image

I guess ODO looks better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bamuel @blopker